Add more font-width data
#26069
Merged
Add more font-width data
#26069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
This probably shouldn't exist.
|
This PR is now ready for review again. I've updated the PR with the relevant SVG data. I also sent w3c/svgwg#978. If we get an answer there, I'll update this PR or send a follow up (depending on how quickly this gets merged). |
caugner
reviewed
May 6, 2025
There was a problem hiding this comment.
LGTM overall, just three comments.
Additional links:
- WebKit bug: https://bugs.webkit.org/show_bug.cgi?id=277673
- Spec issue: [css-fonts-4] font-stretch is unfortunately named w3c/csswg-drafts#551 (comment)
- Initial spec commit: w3c/csswg-drafts@b0660ee
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
caugner
requested changes
May 6, 2025
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
Co-authored-by: Claas Augner <495429+caugner@users.noreply.github.com>
caugner
approved these changes
May 13, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This creates more symmetry between
font-stretchandfont-widthdata.Test results and supporting details
<percentage>value to thefont-widthtree, to matchfont-stretchand fully cover the expected values and types forfont-width.font-widthdata into the@font-facetree, as a descriptor.font-widthSVG global attribute (shipped in Safari, contrary to the implication of the specification)Related issues
font-stretchas deprecated #26060font-widthfeature web-platform-dx/web-features#2707